Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make more clear that configuration page is about the APIcast configuration #1543

Merged
merged 3 commits into from Jan 30, 2020

Conversation

thomasmaas
Copy link
Member

@thomasmaas thomasmaas commented Jan 20, 2020

Closes https://issues.redhat.com/browse/THREESCALE-4242

  • make more clear that this about staging apicast configs and not staging their API
  • show version above promote button so button text doesn't get too long

before:
Screenshot 2020-01-30 15 40 05

after:
Screenshot 2020-01-29 18 23 49

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #1543 into master will decrease coverage by 1.43%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1543      +/-   ##
==========================================
- Coverage   85.81%   84.37%   -1.44%     
==========================================
  Files        2464     2230     -234     
  Lines       80586    69316   -11270     
==========================================
- Hits        69151    58487   -10664     
+ Misses      11435    10829     -606
Impacted Files Coverage Δ
app/helpers/api/integrations_helper.rb 70.14% <0%> (-2.99%) ⬇️
lib/tasks/services.rake 56.66% <0%> (-30.84%) ⬇️
app/lib/cms/s3.rb 75.86% <0%> (-9.44%) ⬇️
.../admin/dashboard/service/top_traffic_controller.rb 71.42% <0%> (-3.58%) ⬇️
...rovider/admin/dashboard/service/hits_controller.rb 50% <0%> (-2.95%) ⬇️
lib/tasks/multitenant/tenants.rake 41.5% <0%> (-5.67%) ⬇️
...est/unit/three_scale/swagger/specification_test.rb 97.43% <0%> (-2.57%) ⬇️
...s/provider/admin/cms/email_templates_controller.rb 41.66% <0%> (-0.65%) ⬇️
...ib/developer_portal/lib/liquid/drops/pagination.rb 91.66% <0%> (-0.2%) ⬇️
app/subscribers/after_commit_subscriber.rb 96.42% <0%> (-0.13%) ⬇️
... and 736 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f0f85f...46428a3. Read the comment docs.

@thomasmaas thomasmaas changed the title [wip] make more clear that configuration page is about the APIcast configuration Make more clear that configuration page is about the APIcast configuration Jan 30, 2020
@thomasmaas thomasmaas merged commit de408f0 into master Jan 30, 2020
@thomasmaas thomasmaas deleted the staging-production-terms branch January 30, 2020 15:50
@thomasmaas thomasmaas self-assigned this Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants