New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to NodeJS 10 in CircleCI #1548
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 22, 2020
hallelujah
reviewed
Jan 23, 2020
hallelujah
reviewed
Jan 24, 2020
josemigallas
force-pushed
the
feature/THREESCALE-4238_node_10
branch
from
January 29, 2020 10:02
4b1930f
to
993cfba
Compare
josemigallas
force-pushed
the
feature/THREESCALE-4238_node_10
branch
3 times, most recently
from
January 29, 2020 12:12
db327dc
to
b83fdde
Compare
Need to retrigger a build when the new image is built in quay |
josemigallas
force-pushed
the
feature/THREESCALE-4238_node_10
branch
from
January 29, 2020 16:06
b83fdde
to
deb9794
Compare
Codecov Report
@@ Coverage Diff @@
## master #1548 +/- ##
==========================================
- Coverage 85.81% 84.43% -1.38%
==========================================
Files 2464 2231 -233
Lines 80586 69444 -11142
==========================================
- Hits 69151 58632 -10519
+ Misses 11435 10812 -623
Continue to review full report at Codecov.
|
This was referenced Jan 29, 2020
Martouta
added
the
Priority: Blocker
This PR is a blocker. Everyone should review and help to close it ASAP.
label
Jan 29, 2020
hallelujah
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Porta must support nodeJS 10
Which issue(s) this PR fixes
THREESCALE-4239: Upgrade to NodeJS 10 in CircleCI
system-builder: 3scale/system-builder#17