Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to NodeJS 10 in CircleCI #1548

Merged
merged 2 commits into from Jan 29, 2020
Merged

Conversation

josemigallas
Copy link
Contributor

@josemigallas josemigallas commented Jan 22, 2020

What this PR does / why we need it:

Porta must support nodeJS 10

Which issue(s) this PR fixes

THREESCALE-4239: Upgrade to NodeJS 10 in CircleCI

system-builder: 3scale/system-builder#17

.circleci/config.yml Outdated Show resolved Hide resolved
@josemigallas josemigallas changed the title Upgrade to NodeJS 10 Upgrade to NodeJS 10 in CircleCI Jan 23, 2020
@josemigallas josemigallas marked this pull request as ready for review January 24, 2020 13:32
@josemigallas josemigallas changed the base branch from master to ruby2.5 January 24, 2020 16:07
@josemigallas josemigallas changed the base branch from ruby2.5 to master January 24, 2020 16:08
@josemigallas josemigallas changed the base branch from master to oas3/fix-circleci-build January 29, 2020 09:07
@josemigallas josemigallas changed the base branch from oas3/fix-circleci-build to master January 29, 2020 09:18
@josemigallas josemigallas force-pushed the feature/THREESCALE-4238_node_10 branch from 4b1930f to 993cfba Compare January 29, 2020 10:02
@josemigallas josemigallas temporarily deployed to preview01 January 29, 2020 10:18 Inactive
@josemigallas josemigallas force-pushed the feature/THREESCALE-4238_node_10 branch 3 times, most recently from db327dc to b83fdde Compare January 29, 2020 12:12
@hallelujah
Copy link
Contributor

Need to retrigger a build when the new image is built in quay

@Martouta Martouta requested review from a team, hallelujah and didierofrivia January 29, 2020 15:57
@josemigallas josemigallas force-pushed the feature/THREESCALE-4238_node_10 branch from b83fdde to deb9794 Compare January 29, 2020 16:06
@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #1548 into master will decrease coverage by 1.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
- Coverage   85.81%   84.43%   -1.38%     
==========================================
  Files        2464     2231     -233     
  Lines       80586    69444   -11142     
==========================================
- Hits        69151    58632   -10519     
+ Misses      11435    10812     -623
Impacted Files Coverage Δ
lib/tasks/services.rake 56.66% <0%> (-30.84%) ⬇️
.../admin/dashboard/service/top_traffic_controller.rb 71.42% <0%> (-3.58%) ⬇️
...rovider/admin/dashboard/service/hits_controller.rb 50% <0%> (-2.95%) ⬇️
...est/unit/three_scale/swagger/specification_test.rb 97.43% <0%> (-2.57%) ⬇️
...s/provider/admin/cms/email_templates_controller.rb 41.66% <0%> (-0.65%) ⬇️
...ib/developer_portal/lib/liquid/drops/pagination.rb 91.66% <0%> (-0.2%) ⬇️
app/subscribers/after_commit_subscriber.rb 96.42% <0%> (-0.13%) ⬇️
app/models/backend_api.rb 95.08% <0%> (-1.75%) ⬇️
app/models/access_token.rb 94.68% <0%> (-1.16%) ⬇️
app/models/proxy.rb 95.56% <0%> (-1.4%) ⬇️
... and 735 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f0f85f...deb9794. Read the comment docs.

@hallelujah hallelujah merged commit a060b4f into master Jan 29, 2020
@hallelujah hallelujah deleted the feature/THREESCALE-4238_node_10 branch January 29, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Blocker This PR is a blocker. Everyone should review and help to close it ASAP.
Projects
None yet
3 participants