[Bugfix] TypeError: superclass mismatch for class AlertsControllerTest #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martouta
changed the title
Martouta
changed the title
duduribeiro
previously approved these changes
Jan 27, 2020
| cinstance1, cinstance2 = [buyer1, buyer2].map { |buyer| FactoryBot.create(:simple_cinstance, plan: plan, user_account: buyer) } | ||
| [cinstance1, cinstance2].each { |cinstance|FactoryBot.create(:limit_alert, account: provider, cinstance: cinstance) } | ||
|
|
||
|
|
There was a problem hiding this comment.
can you get rid of this multiple spaces?
Martouta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to test an issue from the rails 5 branch and I encountered an unrelated error:
The problem was that this class was defined twice but with a different superclass so it is not monkey-patching it but defining it again.
The problem is that one is the functional and the other one is the integration. Functional tests are deprecated so I moved it to integration and I also slightly refactored the test.
This changes works for any Rails version 馃槃