Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rake task to reset proxy config change history #1733

Merged
merged 2 commits into from Feb 27, 2020

Conversation

guicassolato
Copy link
Contributor

@guicassolato guicassolato commented Feb 27, 2020

# run for all provider accounts
rake task proxy:reset_config_change_history

# run for the proxies of provider whose id is <account_id>
rake task proxy:reset_config_change_history[<account_id>] 

Closes THREESCALE-4588

@guicassolato guicassolato self-assigned this Feb 27, 2020
@guicassolato guicassolato temporarily deployed to preview01 February 27, 2020 13:24 Inactive
@guicassolato guicassolato force-pushed the reset-proxy-config-change-history branch from c40785c to 1921644 Compare February 27, 2020 13:36
@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #1733 into master will increase coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1733      +/-   ##
==========================================
+ Coverage   92.66%   93.11%   +0.44%     
==========================================
  Files        2505     2529      +24     
  Lines       82800    84229    +1429     
==========================================
+ Hits        76728    78426    +1698     
+ Misses       6072     5803     -269
Impacted Files Coverage Δ
.../initializers/backport_pg_10_support_to_rails_4.rb 30% <0%> (-50%) ⬇️
config/initializers/postgres.rb 50% <0%> (-50%) ⬇️
config/initializers/access_token_authentication.rb 55.55% <0%> (-22.23%) ⬇️
app/models/application_record.rb 71.11% <0%> (-11.12%) ⬇️
app/queries/new_accounts_query.rb 71.73% <0%> (-10.87%) ⬇️
app/lib/three_scale/api/responder.rb 95.83% <0%> (-2.09%) ⬇️
spec/acceptance/api/feature_spec.rb
...n/user-management-api/buyers_service_plans_test.rb 100% <0%> (ø)
...integration/master/api/services_controller_test.rb 100% <0%> (ø)
.../admin/authentication_providers_controller_test.rb 100% <0%> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91af6cb...c098af2. Read the comment docs.

@guicassolato
Copy link
Contributor Author

Benchmark in preview (all accounts): 53'34''.

@guicassolato guicassolato requested a review from a team February 27, 2020 14:55
thomasmaas
thomasmaas previously approved these changes Feb 27, 2020
Copy link
Member

@thomasmaas thomasmaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably run it in the morning after billing.

Martouta
Martouta previously approved these changes Feb 27, 2020
@Martouta
Copy link
Contributor

Approved but those 53'34' minutes worry me... maybe we should consider releasing the DB (sleep(0.5)) after each batch so other processes can update it in the meantime 🤔 or maybe I am being too paranoic and it is fine 😄 but in that case, we should run it when there isn't much traffic 🤔

@guicassolato guicassolato force-pushed the reset-proxy-config-change-history branch from 1921644 to c098af2 Compare February 27, 2020 15:52
Copy link
Contributor

@Martouta Martouta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@guicassolato guicassolato merged commit 66ee384 into master Feb 27, 2020
@guicassolato guicassolato deleted the reset-proxy-config-change-history branch February 27, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants