[circleci] docker build #183
Conversation
mikz
force-pushed
the
circleci-openshift
branch
2 times, most recently
from
b52ad65
to
a891661
Compare
mikz
force-pushed
the
circleci-openshift
branch
from
a891661
to
e8466a6
Compare
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
- Coverage 92.63% 92.63% -0.01%
==========================================
Files 2341 2341
Lines 74839 74839
==========================================
- Hits 69327 69326 -1
- Misses 5512 5513 +1
Continue to review full report at Codecov.
|
mikz
force-pushed
the
circleci-openshift
branch
from
ecb9579
to
8d26fea
Compare
.circleci/config.yml
Outdated
| - run: | ||
| name: Login to Container Registry | ||
| command: | | ||
| docker login --username "${DOCKER_USERNAME}"\ |
There was a problem hiding this comment.
Why do we need to login? The base images are publicly available I think
There was a problem hiding this comment.
Yeah, It was because of the dependencies for the smoke test. Guess it could be removed now.
| @@ -160,9 +160,9 @@ clean-cache: | |||
|
|
|||
| bundle: ## Installs dependencies using bundler. Run this after you make some changes to Gemfile. | |||
| bundle: Gemfile.prod Gemfile | |||
There was a problem hiding this comment.
I did not know about this thanks!
I think it is available only on 1.11+
rhscl install 1.10 by default. We spoke about that with @guicassolato and agree we should use at least 1.111
So 👍
gsaslis
force-pushed
the
circleci-openshift
branch
from
8d26fea
to
846d58e
Compare
Build dockerfiles
openshift/system/Dockerfileandopenshift/system/Dockerfile.on_premto verify they are still buildable.