Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight SSO Integrations in vertical navigation #1893

Merged

Conversation

srijitamukherjee
Copy link
Contributor

Closes THREESCALE-3548

Verification steps

The title: SSO Integration, in the vertical navigation, under Developer Portal -> Setting-> SSO Integrations, should be highlight when checked.

@josemigallas josemigallas added the ruby Pull requests that update Ruby code label May 20, 2020
@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #1893 into master will increase coverage by 11.89%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1893       +/-   ##
===========================================
+ Coverage   80.80%   92.69%   +11.89%     
===========================================
  Files        2072     2503      +431     
  Lines       62057    82629    +20572     
===========================================
+ Hits        50143    76596    +26453     
+ Misses      11914     6033     -5881     
Impacted Files Coverage Δ
...vider/admin/authentication_providers_controller.rb 95.38% <100.00%> (+55.38%) ⬆️
test/unit/policy_test.rb 100.00% <0.00%> (ø)
...dmin/api/services/mapping_rules_controller_test.rb 100.00% <0.00%> (ø)
...tegration/user-management-api/credit_cards_test.rb 100.00% <0.00%> (ø)
...events/domains/proxy_domains_changed_event_test.rb 100.00% <0.00%> (ø)
test/unit/pricing_rule_test.rb 100.00% <0.00%> (ø)
test/integration/stats/services_test.rb 100.00% <0.00%> (ø)
test/unit/cms/tags_test.rb 100.00% <0.00%> (ø)
test/unit/csv/buyers_exporter_test.rb 100.00% <0.00%> (ø)
...t/integration/user-management-api/policies_test.rb 100.00% <0.00%> (ø)
... and 1107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce8cb1f...e5658ca. Read the comment docs.

@Martouta Martouta changed the title fixing title used in activate_menu Highlight SSO Integrations in vertical navigation May 20, 2020
@Martouta
Copy link
Contributor

Right 😄
image

I would appreciate a test but in this case, I can also accept not having it.

@Martouta Martouta requested review from thomasmaas and a team May 20, 2020 12:42
@hallelujah
Copy link
Contributor

Yes test case not necessary ... active menu is tested but its usage is not correct or it was and we failed to spot this on oauth2 removal

@Martouta Martouta merged commit 0d2ff12 into master May 20, 2020
@Martouta Martouta deleted the THREESCALE-3548-SSO-Integrations-is-not-highlighted branch May 20, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code
Projects
None yet
5 participants