[PortaFly] Removing unused features from Account > Index #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if that’s true |
|
I think we should not remove it. The actions column will apply to the given record and won't be triggering a batch update as how it was meant with bulk actions. |
didierofrivia
requested review from
josemigallas,
damianpm,
cntlsn and
thomasmaas
josemigallas
requested changes
Jun 24, 2020
damianpm
previously approved these changes
Jun 24, 2020
didierofrivia
changed the base branch from
master
to
portafly/refactor-datalist-tests
didierofrivia
force-pushed
the
portafly/THREESCALE-5430_remove-unused-features
branch
from
189148e
to
beb3322
Compare
didierofrivia
force-pushed
the
portafly/refactor-datalist-tests
branch
from
4784fd1
to
cf94756
Compare
didierofrivia
force-pushed
the
portafly/THREESCALE-5430_remove-unused-features
branch
from
beb3322
to
4a7d857
Compare
didierofrivia
force-pushed
the
portafly/THREESCALE-5430_remove-unused-features
branch
from
4a7d857
to
29cf200
Compare
josemigallas
approved these changes
Jun 25, 2020
damianpm
approved these changes
Jun 25, 2020
didierofrivia
deleted the
portafly/THREESCALE-5430_remove-unused-features
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes features not needed in our first version of the account index.
#1985 covers the missing tests.
Which issue(s) this PR fixes
Fixes: https://issues.redhat.com/browse/THREESCALE-5430