Remove programatically Service columns #1978
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore some columns in Service through the Rails 5 way (
ignored_columns
) instead of the old way (overriding thecolumns
class method).This is part of THREESCALE-2635 and follows the investigation done in the comments of THREESCALE-2715
Explanation of each column being ignored
null
isincomplete
and has not been updated for 2 years.null
in the DB.scheduled_for_deletion
.true
which has stateincomplete
and descriptionnot used
and there is only one reference in the code, which I removed too after asking @thomasmaas if it was ok to remove that.Columns not ignored/removed because I am not sure
txt_support and terms for what I explained in this comment