[sphinx] Ensures ThinkingSphinx preloads the all the indices upfront #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martouta
previously approved these changes
Jul 1, 2020
hallelujah
previously approved these changes
Jul 2, 2020
Otherwise concurrent threads (e.g. sidekiq, puma) can deadlock while racing to obtain access to the mutex block at https://github.com/pat/thinking-sphinx/blob/v3.4.2/lib/thinking_sphinx/configuration.rb#L78. This bug was fixed in ThinkingSphinx v4.3.0+. See - pat/thinking-sphinx#1051 - pat/thinking-sphinx#1132
guicassolato
force-pushed
the
fix/sphinx-preload-indices
branch
from
5106ea2
to
0c59a44
Compare
guicassolato
commented
Jul 2, 2020
| # Prevents concurrent threads (e.g. sidekiq, puma) to deadlock while racing to obtain access to the mutex block at https://github.com/pat/thinking-sphinx/blob/v3.4.2/lib/thinking_sphinx/configuration.rb#L78 | ||
| # This is a ThinkingSphinx's known bug, fixed in v4.3.0+ - see: https://github.com/pat/thinking-sphinx/commit/814beb0aa3d9dd1227c0f41d630888a738f7c0d6 | ||
| # See also https://github.com/pat/thinking-sphinx/issues/1051 and https://github.com/pat/thinking-sphinx/issues/1132 | ||
| ThinkingSphinx::Configuration.instance.preload_indices if Rails.env.development? |
There was a problem hiding this comment.
It turns out preloading in production and test envs was not as harmless as I thought it would be:
https://app.circleci.com/pipelines/github/3scale/porta/12581/workflows/1082990c-d295-4d66-83f9-0fac30692c8b
Doing it for development env only.
Martouta
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise concurrent threads (e.g. sidekiq, puma) can deadlock while racing to obtain access to the mutex block at
https://github.com/pat/thinking-sphinx/blob/2ae0c98b8b08242eb623e8eb5e364c4ed0fd3fcb/lib/thinking_sphinx/configuration.rb#L78-L91
This is known bug of ThinkingSphinx, fixed in v4.3.0+.
See