Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update width in tables #2060

Merged
merged 3 commits into from Jul 22, 2020
Merged

Update width in tables #2060

merged 3 commits into from Jul 22, 2020

Conversation

cntlsn
Copy link
Contributor

@cntlsn cntlsn commented Jul 17, 2020

What this PR does / why we need it:

  • Add Width modifiers to define column distribution rules for Accounts index page
  • Add Width modifiers to define column distribution rules for Applications index page
  • Add column distribution rules in UX specs files for pages that include a table

@cntlsn cntlsn added the portafly Issues related to the PortaFly module label Jul 17, 2020
@cntlsn cntlsn self-assigned this Jul 17, 2020
josemigallas
josemigallas approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@josemigallas josemigallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

thomasmaas
thomasmaas approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@thomasmaas thomasmaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe clean up the commits? There are 2 commits with the same name, might be just 1?

@cntlsn
Copy link
Contributor Author

cntlsn commented Jul 21, 2020 •
edited

Maybe clean up the commits? There are 2 commits with the same name, might be just 1?

@thomasmaas Same commit name, but two diff files!

@cntlsn cntlsn changed the title Add Width modifiers to define column distribution rules Update width in tables Jul 22, 2020
@cntlsn cntlsn merged commit 6acea5d into master Jul 22, 2020
@cntlsn cntlsn mentioned this pull request Jul 22, 2020
Merged
@hallelujah hallelujah deleted the portafly/tables-columns-distribution-rules branch September 2, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasmaas thomasmaas thomasmaas approved these changes

@josemigallas josemigallas josemigallas approved these changes

@didierofrivia didierofrivia Awaiting requested review from didierofrivia

@deernano deernano Awaiting requested review from deernano

@damianpm damianpm Awaiting requested review from damianpm

Assignees

@cntlsn cntlsn

Labels
portafly Issues related to the PortaFly module
Projects
None yet
Milestone
No milestone
3 participants
@cntlsn @thomasmaas @josemigallas