Move '.decorate' from view to controller in api/proxy_configs/index #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martouta
force-pushed
the
rm-app/views/api/proxy_configs/index
branch
from
88f443b
to
312d7e1
Compare
Martouta
changed the title
Martouta
added
cleanup
Martouta
commented
Aug 11, 2020
| class Api::ProxyConfigsController < Api::BaseController | ||
| load_and_authorize_resource :service, through: :current_user, through_association: :accessible_services | ||
|
|
||
| activate_menu :serviceadmin, :integration, :configuration | ||
| sublayout 'api/service' | ||
|
|
||
| def index | ||
| if params[:environment].to_s.downcase == 'production'.freeze | ||
| @proxy_configs = proxy_configs.production.paginate(paginate_params) | ||
| @environment_name = 'Production'.freeze |
Martouta
commented
Aug 11, 2020
| @environment_name = 'Production'.freeze | ||
| else | ||
| @proxy_configs = proxy_configs.sandbox.paginate(paginate_params) | ||
| @environment_name = 'Staging'.freeze |
There was a problem hiding this comment.
josemigallas
approved these changes
Aug 11, 2020
hallelujah
pushed a commit
that referenced
this pull request
Sep 10, 2020
…ndex Move '.decorate' from view to controller in api/proxy_configs/index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes THREESCALE-5810