Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gems] Update simplecov and codecov #2372

Merged
merged 5 commits into from Feb 22, 2021
Merged

[gems] Update simplecov and codecov #2372

merged 5 commits into from Feb 22, 2021

Conversation

hallelujah
Copy link
Contributor

@hallelujah hallelujah commented Feb 22, 2021

To work around the failures we see in the CircleCI...

It actually does not fix the actual issue with CodeCov Bash. We just disable it.

{'detail': ErrorDetail(string='Build has already finished, uploads rejected.', code='not_found')}
404

We did all wrong in the past:

  • codecov gem has an auto upload feature (who looks like broken with our ruby/bundler)
  • we also re-upload the results with the bash script given by codecov

This PR fixes that by:

  • letting Ruby generate the codecov reports
  • letting the circleci job to upload the generated reports to codecov

Explanation

Looks like they deployed a feature on Friday 19/02/2021 that rejects uploads
Breaking multiple concurrent builds in CI
See codecov/codecov-bash#411

Notes

  • This is the kind of things that go against deploying on Friday
  • We can't really use after_n_builds in the codecov.yml because we have so much parallelism and builds ... and it could change any time.

To work around the failures we see in the CircleCI
Just generate them using the Codecov::SimpleCov::Formatter

The bash script will take care of uploading it
Looks like they deployed a feature on Friday 19/02/2021 that rejects uploads
Breaking multiple concurrent builds in CI

See codecov/codecov-bash#411

Note:

This is the kind of things that go against deploying on Friday
@hallelujah hallelujah requested review from guicassolato, macejmic and a team February 22, 2021 18:25
@hallelujah hallelujah self-assigned this Feb 22, 2021
@hallelujah hallelujah merged commit cb4e826 into master Feb 22, 2021
@hallelujah hallelujah deleted the fix/codecov branch February 22, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants