Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove apiap from file names #2507

Merged
merged 1 commit into from Jul 15, 2021

Conversation

lvillen
Copy link
Contributor

@lvillen lvillen commented Jul 1, 2021

What this PR does / why we need it:

Removed the apiap names from the files that had it. Also merged duplicated wizard_steps files into one.

Which issue(s) this PR fixes

https://issues.redhat.com/browse/THREESCALE-6766

Verification steps

Run these tests:

bundle exec cucumber features/provider/onboarding/wizard.feature
bundle exec cucumber features/old/providers/wizard_upgrade_plan.feature

Special notes for your reviewer:

@josemigallas josemigallas requested a review from a team July 1, 2021 13:11
@josemigallas josemigallas added the ruby Pull requests that update Ruby code label Jul 1, 2021
guicassolato
guicassolato previously approved these changes Jul 9, 2021
josemigallas
josemigallas previously approved these changes Jul 9, 2021
@hallelujah
Copy link
Contributor

Your commits are not signed, please follow the Contributing guide

@hallelujah hallelujah self-requested a review July 13, 2021 21:10
Copy link
Contributor

@hallelujah hallelujah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please push your commits signed ;)

…d deletes duplicate file \n-fixes codeclimate errors
@josemigallas josemigallas merged commit 24c9bd2 into 3scale:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code
Projects
None yet
4 participants