Using specific Node version

[didierofrivia]

What this PR does / why we need it:

Since we still can't productise Yarn, we need to commit our webpack packs and having different Node version resolves to different packs committed.

Which issue(s) this PR fixes

This will avoid having different packs every time webpack builds them. It also fixed a webpacker - node-sass issue.

Verification steps

• Install node version 8
• rm -rf node_modules
• npm install
• rake webpack:production
• It shouldn't change anything

[mikz]

Is there a difference between Node 10.x versions?

[didierofrivia]

well, minor TBH, we try to stick with latest LTS

[mikz]

so, brew install node@10 should be good too no?

[didierofrivia]

Yes, I could add as a macos alternative

[mikz]

BTW, any reason why not to just use npm instead of yarn? I don't see clear path how yarn gets productized, so just going back to npm does not sound as that big a deal.

[didierofrivia]

@mikz My idea was after #57 is merged, ditch yarn and use just npm. But @hallelujah mentioned the alternative of somehow productize yarn/ocaml since it's default for Rails 5. Still we haven't explored much the latest alternative.

[mikz]

@didierofrivia I don't see yarn productization as something feasible or our task in the first place. Yarn is just a package manager. It is irrelevant for rails what package manager we use to install dependencies. We only need to change relevant rake tasks to run npm instead.

[didierofrivia]

@mikz I wholeheartedly agree with you 👍

[hallelujah]

Please do not forget about https://github.com/3scale/porta/blob/master/openshift/system/contrib/scl_enable#L4

And build an image to try this out before CR1 if you want to have it in CR1 (optional IMO)

[codecov]

Codecov Report

Merging #262 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   92.58%   92.58%   +<.01%     
==========================================
  Files        2359     2359              
  Lines       75471    75471              
==========================================
+ Hits        69874    69875       +1     
+ Misses       5597     5596       -1

Impacted Files	Coverage Δ
app/models/payment_transaction.rb	81.72% <0%> (+1.07%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2946da3...cef0f0b. Read the comment docs.

[didierofrivia]

UPDATE: Latest stable RHEL Node version is 8.3.0, so updating this PR

[damianpm]

Typo, it should be specific Node version

[didierofrivia]

I think I wanted with specific node versions without the a hehe, thanks!