Improve Products index #2633
Merged
Improve Products index #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
damianpm
reviewed
Oct 4, 2021
akostadinov
reviewed
Oct 4, 2021
|
|
||
| def presenter | ||
| @presenter ||= Api::ServicesIndexPresenter.new(current_user: current_user, params: params) | ||
| end |
There was a problem hiding this comment.
Where is this method used?
There was a problem hiding this comment.
It's used in the view:
damianpm
approved these changes
Oct 5, 2021
akostadinov
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The page is visually identical but this PR introduces a series of improvements:
ToolbarSearchfor reusabilityPart 1/2 of THREESCALE-7646: Cleanup/refactor Products and Backends index logic
Before:
After:
Search input:
Imagine the popover message reads:
To search, type at least 3 characters.https://user-images.githubusercontent.com/11672286/136042060-86e2937a-014a-48e1-99aa-ca504caafdac.mp4