Prawn memory leak THREESCALE-8120 #2800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josemigallas
previously approved these changes
Nov 30, 2021
akostadinov
reviewed
Nov 30, 2021
hallelujah
force-pushed
the
memory-leak/pdf-report
branch
from
0899526
to
ff7ec70
Compare
akostadinov
previously approved these changes
Dec 2, 2021
hallelujah
force-pushed
the
memory-leak/pdf-report
branch
from
ff7ec70
to
27d129f
Compare
akostadinov
previously approved these changes
Dec 21, 2021
| nokogiri | ||
| prawn | ||
| prawn-table | ||
| prawn-table (0.2.2) |
There was a problem hiding this comment.
4 years without commits, doesn't prawn-markup handle tables well enough?
Just asking, probably you already checked.
There was a problem hiding this comment.
Note to myself - prawn-markup depends on prawn-table. Also prawn-table had seen some care this year.
hallelujah
force-pushed
the
memory-leak/pdf-report
branch
from
5f736ef
to
11d549f
Compare
Update prawn gem to fix prawnpdf/prawn#424 TODO: -[ ] use 3scale fork and remove the TTF files there to comply with RH license policies
TODO: - [] Make sure that the pdf is generated correctly - [] Make sure all styles are correct
hallelujah
force-pushed
the
memory-leak/pdf-report
branch
2 times, most recently
from
cc994f3
to
2746deb
Compare
TODO: - [] Fix the correct tags
hallelujah
force-pushed
the
memory-leak/pdf-report
branch
from
2746deb
to
dce8bb9
Compare
|
@akostadinov assigning this to you since you were the most involved besides Hery. I think there is no rush but we should not forget about it either. |
|
This PR is stale because it has not received activity for more than 14 days. Remove stale label or comment or this will be closed in 7 days. |
akostadinov
reviewed
Oct 11, 2022
| @@ -1605,9 +1595,14 @@ GEM | |||
| net-http-persistent | |||
| polyamorous (1.3.3) | |||
| activerecord (>= 3.0) | |||
| prawn-format (0.2.1) | |||
| prawn (2.4.0) | |||
There was a problem hiding this comment.
just a note to myself this only supports ruby 2.5+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update prawn gem to fix prawnpdf/prawn#424