馃拃馃敟 Remove forums part 1 #2999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josemigallas
force-pushed
the
remove_forum
branch
from
82b3c59
to
5e640f7
Compare
josemigallas
force-pushed
the
remove_forum
branch
from
38d7132
to
3de7684
Compare
josemigallas
force-pushed
the
remove_forum
branch
from
1dbe775
to
8305b66
Compare
mayorova
reviewed
Oct 19, 2023
| @@ -87,14 +87,6 @@ | |||
| SQL | |||
| end | |||
|
|
|||
| trigger 'forums' do | |||
There was a problem hiding this comment.
I am not sure how this works, but in case it creates triggers in the DB... should we remove the existing triggers via a migration?...
There was a problem hiding this comment.
Probably.. I don't know. I will try to make this PR only about UI and leave DB and backend stuff for later.
josemigallas
force-pushed
the
remove_forum
branch
from
7b1a8d3
to
2f81220
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To hell with it!
THREESCALE-10803: Remove forum code part 3