Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current product showing in Vertical navigation when in Audience #3015

Merged
merged 8 commits into from Sep 6, 2022
Merged

Current product showing in Vertical navigation when in Audience #3015

merged 8 commits into from Sep 6, 2022

Conversation

lvillen
Copy link
Contributor

@lvillen lvillen commented Jul 19, 2022 •
edited

What this PR does / why we need it:

Fixes problems in Vertical navigation.

Which issue(s) this PR fixes

THREESCALE-8216 Current product showing in Vertical navigation when in Audience

Verification steps

  1. Go to Products > Applications > Listing.

  2. Click on an application.

  3. Confirm that when redirected to Audience the product name doesn't appear.

  4. Go to Audience > Applications > Listing.

  5. Click on an application.

  6. Confirm that the product name doesn't appear.

@lvillen lvillen requested review from josemigallas and a team July 19, 2022 14:34
@lvillen lvillen changed the title [WIP] Context selector is not showing the correct section Context selector is not showing the correct section Jul 20, 2022
@lvillen lvillen marked this pull request as ready for review July 20, 2022 09:21
@lvillen lvillen self-assigned this Jul 20, 2022
@lvillen lvillen changed the title Context selector is not showing the correct section Current product showing in Vertical navigation when in Audience Jul 21, 2022
lvillen and others added 2 commits July 26, 2022 13:03
@lvillen @josemigallas
Update vertical_nav_helper
5e453cf 
Co-authored-by: Jose Miguel Gallas Olmedo <josemigallas@gmail.com>
@lvillen
✏️ Fixes typo
c11a9ed
josemigallas
josemigallas requested changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@josemigallas josemigallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need some tests

@github-actions github-actions bot added the Stale label Aug 12, 2022
@github-actions github-actions bot closed this Aug 19, 2022
@lvillen lvillen reopened this Aug 26, 2022
@lvillen lvillen requested a review from a team August 29, 2022 08:46
@github-actions github-actions bot closed this Sep 6, 2022
@lvillen lvillen reopened this Sep 6, 2022
thalesmiguel
thalesmiguel previously approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@thalesmiguel thalesmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✌️

@josemigallas josemigallas merged commit d4491d8 into master Sep 6, 2022
@josemigallas josemigallas deleted the THREESCALE-8216-ContextSelector branch September 6, 2022 14:43
@3scale 3scale deleted a comment from github-actions bot May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayorova mayorova mayorova left review comments

@josemigallas josemigallas josemigallas approved these changes

@thalesmiguel thalesmiguel thalesmiguel left review comments

Assignees

@lvillen lvillen

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@lvillen @mayorova @thalesmiguel @josemigallas