Unwanted text in product settings RadioGroup option

[lvillen]

Which issue(s) this PR fixes

THREESCALE-8556 Unwanted text in product settings RadioGroup option

Verification steps

1. Navigate to Product setting page (/apiconfig/services/{product_id}/settings).
2. Confirm Istio option has only "Istio".

Special notes for your reviewer:

After some considerations, I've decided to delete the unwanted text form the en.yml file instead of hiding it. That text was hidden at version 2.7 and has been like that since, so it made more sense to simply delete it.

[mayorova]

Is this needed? 🤔

[lvillen]

With this line I wanted to test that we can actually change the Deployment option, also that the Istio option was available and that everything was working as expected.

[akostadinov]

I think it is incorrect to set it globally like that. I see tests that expect it to be apicast. I don't know how they pass. But either case, in your test case, you can do:

      put admin_service_path(service), params: update_params(deployment_option: 'service_mesh_istio')

Then check value is what you expect. For example you can do this on line 93 instead of setting it directly.

[akostadinov]

Changes make sense to me.

[akostadinov]

I think it is incorrect to set it globally like that. I see tests that expect it to be apicast. I don't know how they pass. But either case, in your test case, you can do:

      put admin_service_path(service), params: update_params(deployment_option: 'service_mesh_istio')

Then check value is what you expect. For example you can do this on line 93 instead of setting it directly.