🧠🌴 Remove dependency from braintree-web CDN #3206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove dependency from
braintree-web
sdk loaded via CDN by moving the script into a TS file handled by webpack.Additionally there are some minor improvements, namely:
Possible scenarios:
Scenarios 1: hosted fields failure
Scenario 2: wrong client token
Scenario 3: wrong credit card
Scenario 4: braintree error after submission
Which issue(s) this PR fixes
THREESCALE-9152: Remove double dependency from braintree-web SDK
Verification steps
You can verify it still works by going to
Account Settings > Billing > Payment Details > edit
(AKA
/p/admin/account/braintree_blue/edit
)Then use any of the Braintree test credit cards, such as:
4000000000001000
with any valid exp. date and CVV.