Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 ⚰️ Authorize.net is dead #3224

Closed
wants to merge 3 commits into from

Conversation

josemigallas
Copy link
Contributor

@josemigallas josemigallas commented Feb 24, 2023

THREESCALE-6549: Remove all traces of 'authorize.net' from the code and the DB

QUESTION: I needed to restart the server for Liquid to reload tags. What will happen in production?

TODOs

  • Remove column from Oracle schema
  • Check if any client is still using Authorize net
  • Coordinate DB migration with ops, probably do in a separate PR

@josemigallas josemigallas self-assigned this Feb 24, 2023
@akostadinov
Copy link
Contributor

Well old pods are deleted and new pods are started with a new server.

Comment on lines +1 to +5
class RemoveAuthorizeNetCCtokenFromAccount < ActiveRecord::Migration[5.2]
def change
safety_assured { remove_column :accounts, :credit_card_authorize_net_payment_profile_token }
end
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this: https://github.com/ankane/strong_migrations#removing-a-column

The app should be restarted to be sure this migration doesn't cause problems, def. we'll need ops assistance to deploy this. But to be sure it doesn't cause any problem, another PR with only the self.ignored_columns = %i[credit_card_authorize_net_payment_profile_token] added to the Account model should be merged and deployed first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the Stale label Mar 23, 2023
@github-actions github-actions bot closed this Mar 30, 2023
@josemigallas josemigallas reopened this Mar 30, 2023
@@ -1,12 +0,0 @@
module Liquid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to leave it here, the same way we did with the ogone form liquid.

@github-actions github-actions bot removed the Stale label Mar 31, 2023
@github-actions github-actions bot added the Stale label Apr 15, 2023
@3scale 3scale deleted a comment from github-actions bot Apr 17, 2023
@3scale 3scale deleted a comment from github-actions bot Apr 17, 2023
@github-actions github-actions bot added the Stale label May 2, 2023
@3scale 3scale deleted a comment from github-actions bot May 3, 2023
@josemigallas josemigallas removed the Stale label May 3, 2023
@mayorova
Copy link
Contributor

mayorova commented May 5, 2023

This needs quite some work to resolve all conflicts 🥲

Maybe move it to Draft for now as it's not a priority?

@github-actions github-actions bot added the Stale label May 20, 2023
@josemigallas josemigallas marked this pull request as draft June 6, 2023 15:26
@github-actions github-actions bot added the Stale label Jun 21, 2023
@github-actions github-actions bot closed this Jun 28, 2023
@mayorova mayorova deleted the THREESCALE-6549_cleanup_authorize_net branch October 3, 2023 10:54
@3scale 3scale deleted a comment from github-actions bot Feb 8, 2024
@3scale 3scale deleted a comment from github-actions bot Feb 8, 2024
@josemigallas josemigallas restored the THREESCALE-6549_cleanup_authorize_net branch February 8, 2024 08:01
@josemigallas josemigallas reopened this Feb 8, 2024
@github-actions github-actions bot removed the Stale label Feb 9, 2024
@jlledom
Copy link
Contributor

jlledom commented Feb 22, 2024

This one makes a year in a couple of days!

@josemigallas josemigallas force-pushed the THREESCALE-6549_cleanup_authorize_net branch from afefcc1 to 702df39 Compare February 26, 2024 08:26
@josemigallas josemigallas changed the title 🚧 ⚰️ Authorize.net is dead 🚧 ⚰️ Authorize.net is dead: cleanup code Feb 26, 2024
@josemigallas josemigallas changed the title 🚧 ⚰️ Authorize.net is dead: cleanup code 🚧 ⚰️ Authorize.net is dead: code Feb 26, 2024
@josemigallas
Copy link
Contributor Author

Closing in favor of smaller PRs, since migration needs it. Code removal now at #3701

@josemigallas josemigallas changed the title 🚧 ⚰️ Authorize.net is dead: code 🚧 ⚰️ Authorize.net is dead Feb 26, 2024
@josemigallas josemigallas deleted the THREESCALE-6549_cleanup_authorize_net branch February 26, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants