-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚛️ Finish React implementation of Plans index #3381
Conversation
It says
|
844dc05
to
c2f7423
Compare
9760d72
to
dd8bc26
Compare
dd8bc26
to
737a72a
Compare
737a72a
to
87670b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small consistency change, but nice approach for plans-handling!
I'm wondering if it would be nice to actually make a single component, e.g. PlansIndexPage, and handle the differences with different props, i.e. pass "title", "subtitle", "helperText" and "warning" (showNotice thingy) to the component, and this way make it generic. But it's OK if not. It's already very much unified 👍 |
It's really hard to say when to stop making generic things. I think, since these are 3 different models, they belong to 3 different realms and therefore should have different controllers, presenters, etc. |
THREESCALE-9630: Unify plans components into a whole React page
Now all 3 plans pages are fully implemented with Patternfly React.
Before
After