Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃 Implement provider footer with PF4 #3385

Merged
merged 2 commits into from
May 26, 2023
Merged

Conversation

josemigallas
Copy link
Contributor

THREESCALE-9640: Remove hardcoded styles in footer

Apply Patternfly structure and classes to footer. It looks closer now now closer to the main section, have in mind that's Patternfly's default.

Before

Screenshot 2023-05-25 at 19 19 09

After

Screenshot 2023-05-25 at 19 11 51

Error layout

The error layout does not support Patternfly, therefore its footer is to remain unchanged.

Before

Screenshot 2023-05-25 at 19 03 08

After

Screenshot 2023-05-25 at 19 06 24

@josemigallas josemigallas self-assigned this May 25, 2023
@josemigallas josemigallas requested a review from a team May 25, 2023 17:26
@josemigallas josemigallas changed the title 馃 implements provider footer with PF4 馃 Implement provider footer with PF4 May 26, 2023
@josemigallas josemigallas merged commit 5afb9bb into master May 26, 2023
17 of 21 checks passed
@josemigallas josemigallas deleted the THREESCALE-9640_footer branch May 26, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants