馃 Secondary nav (formerly known as menu) #3399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josemigallas
changed the title
josemigallas
force-pushed
the
THREESCALE-9660_buyers_menu
branch
from
5eb0ac5
to
1861424
Compare
josemigallas
changed the title
josemigallas
changed the title
lvillen
previously approved these changes
Jun 6, 2023
josemigallas
force-pushed
the
THREESCALE-9660_buyers_menu
branch
from
5941e68
to
cc39d5b
Compare
josemigallas
commented
Jun 7, 2023
| @@ -1,13 +0,0 @@ | |||
| ul#subsubmenu | |||
There was a problem hiding this comment.
This menu isn't rendered anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THREESCALE-9660: Change page header menus with Breadcrumb or secondary nav
Before
Mix of breadcrumb and tertiary nav apparently but it's really just a tertiary nav.
After
The most similar component is the legacy tertiary navigation. An up to date version should maybe use a secondary navigation. But we want it to be as close as it can be to master, so here's the legacy tertiary nav:
