Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Discovery] Fix API endpoint without path #357

Merged
merged 2 commits into from Nov 22, 2018

Conversation

guicassolato
Copy link
Contributor

@guicassolato guicassolato commented Nov 22, 2018

What this PR does / why we need it:

It's currently not possible to set the annotation discovery.3scale.net/path to empty string or "/".

Which issue(s) this PR fixes

THREESCALE-1587

Verification steps

  • Set the discovery.3scale.net/path annotation of a service to "/" or empty string
  • Import the service from OpenShift into 3scale
  • system-sidekiq container should raise an error:
WARN: TypeError: no implicit conversion of nil into String
WARN: /opt/system/app/models/service_discovery/cluster_service.rb:36:in `join'

Special notes for your reviewer:

@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #357 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   92.58%   92.58%   +<.01%     
==========================================
  Files        2340     2340              
  Lines       75661    75673      +12     
==========================================
+ Hits        70048    70060      +12     
  Misses       5613     5613
Impacted Files Coverage Δ
...est/unit/service_discovery/cluster_service_test.rb 98.3% <100%> (+0.43%) ⬆️
app/models/service_discovery/cluster_service.rb 96.96% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8d998...9154905. Read the comment docs.

@guicassolato guicassolato added the bug Something isn't working label Nov 22, 2018
@guicassolato guicassolato changed the title [wip] [Service Discovery] Fix API endpoint without path [Service Discovery] Fix API endpoint without path Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants