Updating create account text

[damianpm]

What this PR does / why we need it:

Update the page to create accounts in the Master Admin Portal to: Create new account

Which issue(s) this PR fixes

https://issues.jboss.org/browse/THREESCALE-1782

Special notes for your reviewer:
@thomasmaas , please review locally with Master account

Before:

After:

[thomasmaas]

so lets move the if - else inline as now the only difference is the path

[Martouta]

I agree 😄 It is simpler:

th class="actions"
  - if can?(:create, Account)
    = link_to 'Create', (current_account.master? ? new_provider_admin_account_path : new_admin_buyers_account_path), title: 'Create new account', class: 'action add'

And with this I am assuming that can?(:create, Account) for a master is always true, which should be, otherwise what we currently have here is already wrong 😄

[damianpm]

@Martouta @thomasmaas , I simplified it, can you check?

[codecov]

Codecov Report

Merging #514 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
+ Coverage   92.69%   92.69%   +<.01%     
==========================================
  Files        2344     2344              
  Lines       75748    75764      +16     
==========================================
+ Hits        70213    70231      +18     
+ Misses       5535     5533       -2

Impacted Files	Coverage Δ
app/models/contract.rb	94.92% <0%> (-0.04%)	⬇️
test/workers/zync_worker_test.rb	100% <0%> (ø)	⬆️
...nts/applications/application_deleted_event_test.rb	100% <0%> (ø)	⬆️
test/unit/contract_test.rb	100% <0%> (ø)	⬆️
...pec/acceptance/api/line_item_variable_cost_spec.rb
spec/acceptance/api/feature_spec.rb	100% <0%> (ø)
app/events/zync_event.rb	83.33% <0%> (+2.08%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ab845...53871d0. Read the comment docs.

[Martouta]

This changes the behaviour in a risky way because right now we are not checking the case of not being a master and can?(:create, Account) being false 😞

[damianpm]

This changes the behaviour in a risky way because right now we are not checking the case of not being a master and can?(:create, Account) being false 😞
@Martouta can you check again?

[thomasmaas]

Suggested change

	- if can?(:create, current_account)
	- if can?(:create, Account)

[damianpm]

I tried that @thomasmaas @Martouta , it works for a provider, but not for master

[Martouta]

- if can?(:create, Account) 😄
This means if the current_user can create from the model Account, while what there is currently in the code here means if the current_user can create the current_account 😂

[Martouta]

What the controller is doing is:

porta/app/controllers/provider/admin/accounts_controller.rb

Line 10 in c865ad5

before_action :check_provider_signup_possible, :only => %i[new create]

porta/app/controllers/provider/admin/accounts_controller.rb

Lines 65 to 67 in c865ad5

	def check_provider_signup_possible
	redirect_to admin_buyers_accounts_path, alert: 'Please, create an Account Plan and a Service Plan first' unless current_account.signup_provider_possible?
	end

porta/app/lib/logic/provider_signup.rb

Lines 9 to 12 in c865ad5

	def signup_provider_possible?
	ensure_master
	!!(services.default && account_plans.default && services.default.service_plans.default)
	end

Imo in the case of member users we should check also user.has_permission?(:partners) but that would be changing the current behaviour so that's why I didn't do it 🤔

Done :)