Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Position for mapping rules #554

Merged
merged 15 commits into from Feb 22, 2019

Conversation

macejmic
Copy link
Contributor

What this PR does / why we need it:

Replace this with a quick explanation of what's included here.

Which issue(s) this PR fixes

Replace this comment with references to related issues. This will ensure the issue(s) are closed automatically when the PR gets merged.
e.g. fixes #<issue number>(, fixes #<issue_number>, ...)

Verification steps

Replace this with a list of necessary steps to verify the PR meets your expectations.
e.g. 1. Go to Admin Portal, make sure that ...

Special notes for your reviewer:

@macejmic macejmic changed the base branch from master to feature/sorting-mapping-rules January 25, 2019 09:40
@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #554 into feature/sorting-mapping-rules will increase coverage by <.01%.
The diff coverage is 98.03%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           feature/sorting-mapping-rules     #554      +/-   ##
=================================================================
+ Coverage                          92.72%   92.72%   +<.01%     
=================================================================
  Files                               2353     2353              
  Lines                              76216    76262      +46     
=================================================================
+ Hits                               70669    70714      +45     
- Misses                              5547     5548       +1
Impacted Files Coverage Δ
test/workers/delete_plain_object_worker_test.rb 100% <100%> (ø) ⬆️
app/models/proxy_rule.rb 98.3% <100%> (+0.05%) ⬆️
test/integration/api/integration_test.rb 100% <100%> (ø) ⬆️
app/controllers/api/integrations_controller.rb 74.81% <88.88%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c8ffe0...f2e4348. Read the comment docs.

@macejmic macejmic force-pushed the mapping-rules-position branch 3 times, most recently from 50cfe7e to 1e1a43e Compare February 11, 2019 14:24
@didierofrivia didierofrivia merged commit f2e4348 into feature/sorting-mapping-rules Feb 22, 2019
@Martouta Martouta deleted the mapping-rules-position branch June 12, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants