New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Position for mapping rules #554
Merged
didierofrivia
merged 15 commits into
feature/sorting-mapping-rules
from
mapping-rules-position
Feb 22, 2019
Merged
[WIP] Position for mapping rules #554
didierofrivia
merged 15 commits into
feature/sorting-mapping-rules
from
mapping-rules-position
Feb 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macejmic
changed the base branch from
master
to
feature/sorting-mapping-rules
January 25, 2019 09:40
* Done the easiest way * This is meant to remove in the near future favoring an entire page craft in React using APIcast json schema config. * Missing some styling
didierofrivia
force-pushed
the
feature/sorting-mapping-rules
branch
from
February 5, 2019 10:47
51f1ca1
to
eeb5030
Compare
hallelujah
force-pushed
the
mapping-rules-position
branch
from
February 5, 2019 10:49
099b314
to
96e4edc
Compare
Codecov Report
@@ Coverage Diff @@
## feature/sorting-mapping-rules #554 +/- ##
=================================================================
+ Coverage 92.72% 92.72% +<.01%
=================================================================
Files 2353 2353
Lines 76216 76262 +46
=================================================================
+ Hits 70669 70714 +45
- Misses 5547 5548 +1
Continue to review full report at Codecov.
|
macejmic
force-pushed
the
mapping-rules-position
branch
3 times, most recently
from
February 11, 2019 14:24
50cfe7e
to
1e1a43e
Compare
didierofrivia
force-pushed
the
feature/sorting-mapping-rules
branch
from
February 11, 2019 16:01
eeb5030
to
3c8ffe0
Compare
…cale/porta into feature/sorting-mapping-rules
macejmic
force-pushed
the
mapping-rules-position
branch
from
February 11, 2019 16:11
413ce5f
to
11d2b05
Compare
macejmic
force-pushed
the
mapping-rules-position
branch
from
February 19, 2019 13:43
9e5a008
to
12f9ee5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes
Verification steps
Special notes for your reviewer: