Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken links #7

Merged
merged 3 commits into from Nov 15, 2018
Merged

fix broken links #7

merged 3 commits into from Nov 15, 2018

Conversation

gsaslis
Copy link
Member

@gsaslis gsaslis commented Sep 19, 2018

@gsaslis gsaslis changed the title [docs] fixed broken links in contributing guide [WIP] fix broken links Sep 19, 2018
@gsaslis
Copy link
Member Author

gsaslis commented Sep 19, 2018

@3scale/system actually, while searching for 3scale/system i found several other broken links, referencing either now-non-existent GH issues, or other references / naming.

has this already been discussed / acknowledged that there is this (temporary) disconnect, while the final name is decided?

@gsaslis
Copy link
Member Author

gsaslis commented Sep 19, 2018

i think the 2 worth considering at this point (apart from issue / pr mentions) are:

porta/Makefile

Line 36 in c967043

DOCKER_ENV += PERCY_PROJECT=3scale/system PERCY_BRANCH=$(subst origin/,,$(GIT_BRANCH)) PERCY_COMMIT=$(GIT_COMMIT)

"repository": "github.com:3scale/system.git",

@gsaslis gsaslis changed the title [WIP] fix broken links fix broken links Sep 19, 2018
@didierofrivia
Copy link
Member

didierofrivia commented Sep 19, 2018

keep in mind we will change the name of the repo eventually, so the renaming will happen again hehe, so probably just wait until then?

@Martouta
Copy link
Contributor

Can we use relative paths then? 🤔

@mikz
Copy link
Contributor

mikz commented Sep 19, 2018

Also, consider something like APIcast does. An automated tool that checks all links in .md files.
https://github.com/3scale/apicast/blob/4cad7a719fe3769fc2bf89d4929628efdca47e2d/Makefile#L232-L236

@y-tabata
Copy link

How about the 3scale/openshift-templates link here?
3scale/openshift-templates is not found from external.

@Martouta
Copy link
Contributor

what should happen with this PR? it has been opened for very long time now 🤔
is the PR still valid and ready? then rebase from master plz
If it is ready, then @didierofrivia and @mikz should review, or anyone from @3scale/system actually...

@gsaslis
Copy link
Member Author

gsaslis commented Nov 14, 2018

@Martouta thanks for reviving.
I resolved conflicts

Copy link
Contributor

@Martouta Martouta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍 Right now it doesn't seem that we are gonna change the name of the repo again so better to leave everything working and if we change the name, we can change these things again 😉

@Martouta Martouta merged commit 8bce6a2 into master Nov 15, 2018
@Martouta Martouta deleted the hotfix/broken_links branch November 15, 2018 15:03
jlledom added a commit to jlledom/porta that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants