Custom Policy Deletion #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didierofrivia
force-pushed
the
feature/custom-policy-delete-button
branch
from
54bdf14
to
40859b6
Compare
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
=========================================
Coverage ? 92.86%
=========================================
Files ? 2388
Lines ? 77734
Branches ? 0
=========================================
Hits ? 72185
Misses ? 5549
Partials ? 0
Continue to review full report at Codecov.
|
didierofrivia
requested review from
hallelujah,
josemigallas,
thomasmaas,
damianpm and
guicassolato
didierofrivia
force-pushed
the
feature/custom-policy-delete-button
branch
from
44eba3c
to
d09e1f1
Compare
josemigallas
requested changes
Mar 27, 2019
| @@ -66,3 +66,5 @@ export type ElementEventTemplate<E> = { | |||
| } & Event & SyntheticEvent<> | |||
|
|
|||
| export type InputEvent = ElementEventTemplate<HTMLInputElement> | |||
|
|
|||
| export type Window = any | |||
There was a problem hiding this comment.
Should this go in libdefs.js?
| @@ -44,9 +44,18 @@ function CSRFToken ({win = window}: {win?: any}) { | |||
| ) | |||
| } | |||
|
|
|||
| function CustomPolicyForm ({policy, onChange}: {policy: Policy, onChange: OnChange}) { | |||
| function CustomPolicyForm ({policy, onChange, win = window}: {policy: Policy, onChange: OnChange, win?: Window}) { | |||
| const isNewPolicy = !(policy.id && policy.id !== 0) | |||
There was a problem hiding this comment.
To fix codeclimate complexity error, maybe
Suggested change
| const isNewPolicy = !(policy.id && policy.id !== 0) | |
| const isNewPolicy = !policy.id |
didierofrivia
force-pushed
the
feature/custom-policy-delete-button
branch
2 times, most recently
from
8fe7a31
to
6a78e20
Compare
josemigallas
previously approved these changes
Mar 27, 2019
* Works better with hooks and shallow renderinig
[codeclimate] Fixing some issues
* Added pseudo type Window
guicassolato
force-pushed
the
feature/custom-policy-delete-button
branch
from
6a78e20
to
872bc33
Compare
thomasmaas
previously approved these changes
Mar 27, 2019
| @@ -43,11 +43,21 @@ def create | |||
| end | |||
| end | |||
|
|
|||
| def edit; end | |||
There was a problem hiding this comment.
You don't need this I think.
There was a problem hiding this comment.
I guess code climate will complain without it :/
There was a problem hiding this comment.
I think you are right and Code Climate should not complain. I will remove
There was a problem hiding this comment.
Codeclimate complained about it, that was why hehe
damianpm
previously approved these changes
Mar 27, 2019
thomasmaas
previously approved these changes
Mar 27, 2019
guicassolato
force-pushed
the
feature/custom-policy-delete-button
branch
from
906f498
to
872bc33
Compare
thomasmaas
approved these changes
Mar 27, 2019
guicassolato
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing Policy not in use
Removing Policy in use is not possible
What this PR does / why we need it:
Makes it possible to delete a policy from the UI
Which issue(s) this PR fixes
fixes https://issues.jboss.org/browse/THREESCALE-2100
Verification steps
Special notes for your reviewer: