Enable for on-prem the deletion of accounts scheduled for deletion #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martouta
requested review from
hallelujah,
guicassolato,
didierofrivia,
macejmic and
a team
Martouta
force-pushed
the
delete_scheduled
branch
from
fefa878
to
d00dddd
Compare
|
Create a Jira issue mentioning this, so we won't forget about it ;) |
guicassolato
reviewed
Apr 1, 2019
| @@ -4,6 +4,8 @@ class FindAndDeleteScheduledAccountsWorker | |||
| include Sidekiq::Worker | |||
|
|
|||
| def perform | |||
| # TODO: remove this condition before 2.6 | |||
There was a problem hiding this comment.
I wouldn't add this comment. Right now no one imagines we could keep this longer than that, but we never know.
I think a Jira should be enough to remember.
There was a problem hiding this comment.
Makes sense @guicassolato, also, we hide the nasty details hehehe
There was a problem hiding this comment.
The Jira issue THREESCALE-2204 - Fix efficiency to destroy tenants or services has just been created now 😉
Martouta
force-pushed
the
delete_scheduled
branch
from
d00dddd
to
adcee06
Compare
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
===========================================
- Coverage 92.86% 68.75% -24.12%
===========================================
Files 2390 843 -1547
Lines 77797 25846 -51951
===========================================
- Hits 72246 17770 -54476
- Misses 5551 8076 +2525
Continue to review full report at Codecov.
|
guicassolato
previously approved these changes
Apr 1, 2019
macejmic
previously approved these changes
Apr 1, 2019
didierofrivia
previously approved these changes
Apr 1, 2019
Martouta
dismissed stale reviews from didierofrivia, macejmic, and guicassolato
via
1ca19c8
Martouta
force-pushed
the
delete_scheduled
branch
from
1ca19c8
to
e3ddbc3
Compare
guicassolato
previously approved these changes
Apr 1, 2019
Martouta
added
ruby
hallelujah
previously approved these changes
Apr 1, 2019
Test deletion of tenants enabled only for on-prem
Martouta
force-pushed
the
delete_scheduled
branch
from
e3ddbc3
to
f7d9a94
Compare
guicassolato
approved these changes
Apr 1, 2019
didierofrivia
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise tenants won't be destroyed at all for on-prem.
We need to fix the problem of destroying many at once for SaaS before enabling it for SaaS.