Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application update events don't trigger zync when first*traffic_at fields are updated #753

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Martouta
Copy link
Contributor

@Martouta Martouta commented Apr 9, 2019

@Martouta Martouta self-assigned this Apr 9, 2019
@Martouta Martouta force-pushed the THREESCALE-2072 branch 2 times, most recently from 5d32b7b to 353eac1 Compare April 9, 2019 14:27
@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #753 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
- Coverage   92.93%   92.86%   -0.07%     
==========================================
  Files        2395     2392       -3     
  Lines       78189    77861     -328     
==========================================
- Hits        72663    72304     -359     
- Misses       5526     5557      +31
Impacted Files Coverage Δ
app/models/cinstance.rb 96.51% <100%> (+0.02%) ⬆️
test/unit/cinstance_test.rb 100% <100%> (ø) ⬆️
.../initializers/backport_pg_10_support_to_rails_4.rb 30% <0%> (-50%) ⬇️
config/initializers/postgres.rb 50% <0%> (-50%) ⬇️
lib/tasks/multitenant/tenants.rake 53.84% <0%> (-46.16%) ⬇️
config/initializers/access_token_authentication.rb 55.55% <0%> (-22.23%) ⬇️
app/models/application_record.rb 62.5% <0%> (-18.75%) ⬇️
app/queries/new_accounts_query.rb 71.73% <0%> (-10.87%) ⬇️
lib/tasks/impersonation_admin_user.rake 90% <0%> (-10%) ⬇️
app/lib/three_scale/api/responder.rb 95.74% <0%> (-2.13%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebf539c...443f109. Read the comment docs.

@Martouta Martouta force-pushed the THREESCALE-2072 branch 9 times, most recently from 48f510a to 16d8453 Compare April 9, 2019 17:45
@Martouta Martouta changed the title [WIP] Application update events don't trigger zync when first*traffic_at fields are updated Application update events don't trigger zync when first*traffic_at fields are updated Apr 9, 2019
guicassolato
guicassolato previously approved these changes Apr 9, 2019
@Martouta
Copy link
Contributor Author

Martouta commented Apr 9, 2019

image

It was passing tests, codeclimate, and approved by Gui. I repushed only for this, so I am merging it now since it is the exact same code 😄

@Martouta Martouta merged commit 73fe181 into master Apr 9, 2019
@Martouta Martouta deleted the THREESCALE-2072 branch April 9, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants