Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] Fix redirect_url update link #79

Merged
merged 1 commit into from Oct 2, 2018
Merged

[Hotfix] Fix redirect_url update link #79

merged 1 commit into from Oct 2, 2018

Conversation

Martouta
Copy link
Contributor

@Martouta Martouta commented Oct 2, 2018 •
edited by hallelujah

Hotfix for https://issues.jboss.org/browse/THREESCALE-1357

  1. Go to the show page of an application
  2. Click Edit, enter the url in a popup and click Save
  3. It showed 404 Not Found page because it tried to make a POST request to provider-url/apiconfig/services/:service_id/applications/:application_id

I broke this in 29f64d5#diff-51ecc5cd2637a2e14f8651147ed56f9bR3 馃槉 sorry 馃槥

@Martouta Martouta self-assigned this Oct 2, 2018
@hallelujah
Copy link
Contributor

I see that there was no test for this form.
Can you submit a simple one?

thomasmaas
thomasmaas approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@thomasmaas thomasmaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree there should be a test but it could be a separate pull so this [hotfix] can get deployed before more customers open tickets

@Martouta
Copy link
Contributor Author

Martouta commented Oct 2, 2018

image

@hallelujah
Copy link
Contributor

OK I agree with @thomasmaas

@Martouta
Copy link
Contributor Author

Martouta commented Oct 2, 2018

Ok, running Jenkins 馃憤 my email will tell me tomorrow to do the test 馃挭 馃槀 馃拑

@Martouta Martouta merged commit 66cb07a into master Oct 2, 2018
@Martouta Martouta deleted the fix/redirect-url branch October 2, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasmaas thomasmaas thomasmaas approved these changes

@hallelujah hallelujah hallelujah approved these changes

@mayorova mayorova Awaiting requested review from mayorova

Assignees

@Martouta Martouta

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Martouta @hallelujah @thomasmaas