Bump faraday version to 0.12.2 #797
Conversation
guicassolato
force-pushed
the
bump/faraday
branch
from
0e0c812
to
d3e2544
Compare
guicassolato
force-pushed
the
bump/faraday
branch
from
d3e2544
to
e5c3d29
Compare
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
==========================================
- Coverage 92.9% 92.89% -0.01%
==========================================
Files 2414 2414
Lines 78251 78251
==========================================
- Hits 72696 72693 -3
- Misses 5555 5558 +3
Continue to review full report at Codecov.
|
guicassolato
changed the title
test/test_helpers/backend.rb
Outdated
| @@ -85,7 +85,7 @@ def raise_on_method(klass, *methods) | |||
| MockCore.mock_core! | |||
|
|
|||
| def stub_core_integration_errors(service_id: ) | |||
| MockCore.stubs.get("/internal/services/#{service_id}/errors/", {'User-Agent' => 'Faraday v0.9.2'}) do | |||
| MockCore.stubs.get("/internal/services/#{service_id}/errors/", {'User-Agent' => 'Faraday v0.12.2'}) do | |||
There was a problem hiding this comment.
Do we need this header?
I think it does not make any harm to remove it. @3scale/system
There was a problem hiding this comment.
This is for tests 🤔 We can try to remove it and if all tests pass, all good 😄
There was a problem hiding this comment.
I think Faraday sets it accordingly when omitted: https://github.com/lostisland/faraday/blob/v0.12.2/lib/faraday/connection.rb#L102
Now we could also use Faraday.default_connection_options if we're not really aiming to assert anything that could differ based on the User-Agent: https://stackoverflow.com/questions/45622842/globally-configure-faraday-user-agent
There was a problem hiding this comment.
Well I do not see the point of testing this header.
If it was on purpose then I do not know the purpose of it.
There was a problem hiding this comment.
Tests fail if a fixed User-Agent is provided and it mismatches the actual Faraday version.
Faraday sets the User-Agent header according to the version of the gem if not specified: https://github.com/lostisland/faraday/blob/v0.12.2/lib/faraday/connection.rb#L102
What this PR does / why we need it
It updates the version of the faraday gem in use to v0.12.2.
Which issue(s) this PR fixes
This is expected to include support to no_proxy env var in the HTTP requests performed using the gem, such as connections to backend, segment and some requests performed by Sidekiq.
Closes THREESCALE-1739