Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audited changes included into audits to STDOUT #878

Merged
merged 1 commit into from Jun 14, 2019

Conversation

guicassolato
Copy link
Contributor

@guicassolato guicassolato commented Jun 12, 2019

What this PR does / why we need it:

This PR adds to the audits to STDOUT trail the actual changes to the audited model.
It also introduces an option sensitive_attributes: Array to Audited#audited method, where whatever attribute name listed in this option will have its value obfuscated in the audit trail.

Which issue(s) this PR fixes

Closes THREESCALE-2788

@guicassolato guicassolato self-assigned this Jun 12, 2019
@guicassolato guicassolato force-pushed the THREESCALE-2593-audited-changes-to-stdout branch from fdea7be to 5a3debf Compare June 12, 2019 14:51
@guicassolato guicassolato marked this pull request as ready for review June 13, 2019 08:09
@guicassolato guicassolato requested a review from a team June 14, 2019 09:26
Copy link
Contributor

@Martouta Martouta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it 👍 Great job! 🥇 💪

@Martouta Martouta merged commit bc78c95 into master Jun 14, 2019
@Martouta Martouta deleted the THREESCALE-2593-audited-changes-to-stdout branch June 14, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants