Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Adyen payment gateway #882

Merged
merged 1 commit into from Jun 19, 2019
Merged

Deprecate Adyen payment gateway #882

merged 1 commit into from Jun 19, 2019

Conversation

duduribeiro
Copy link
Contributor

@duduribeiro duduribeiro commented Jun 12, 2019 •
edited

What this PR does / why we need it:

Deprecate Adyen payment gateway and remove the option for choosing it in Billing Settings page. It will continue active for accounts already using it but they won't be able to switch back if they change it.

Update Account Management API to remove Adyen references.

Which issue(s) this PR fixes

Closes THREESCALE-2769

Verification steps

  1. Access the Admin Portal with a Provider that has Adyen configured as the payment gateway.
  2. It should keep Adyen as the provider's gateway but alert it with a deprecated message:

image

  1. Change the gateway to another one and hit Save Changes.
  2. It should change the provider's gateway and don't list Adyen in the list.

image

@duduribeiro duduribeiro force-pushed the deprecate_adyen branch 2 times, most recently from 285e185 to aaf4d7a Compare June 13, 2019 18:28
@duduribeiro duduribeiro changed the title [wip] deprecate adyen Deprecate Adyen payment gateway Jun 13, 2019
@duduribeiro duduribeiro marked this pull request as ready for review June 13, 2019 18:50
@duduribeiro duduribeiro self-assigned this Jun 13, 2019
@duduribeiro duduribeiro requested a review from a team June 13, 2019 19:10
@hallelujah
Copy link
Contributor

hallelujah commented Jun 14, 2019 •
edited

Bogus should not be there but it is not your fault :)
LGTM

Test failing on postgres and oracle is a mistake we made on a recent PR merge
I will issue a PR tomorrow

Not approved yet because there is a small question waiting for an answer as well as the PR for oracle and postgres

hallelujah
hallelujah reviewed Jun 14, 2019
View reviewed changes
app/controllers/admin/api/credit_cards_controller.rb Outdated
@@ -15,8 +15,8 @@ class Admin::Api::CreditCardsController < Admin::Api::BaseController
#
##~ op.parameters.add @parameter_access_token
##~ op.parameters.add @parameter_account_id_by_id
##~ op.parameters.add :dataType => "string", :required => true, :paramType => "query", :name => "credit_card_token", :description => "Token used by the payment gateway to identify the buyer -- shopper reference (Adyen), customer profile ID (Authorize.net), customer ID (Braintree and Stripe), customer alias (Ogone-Ingenico). Some payment gateways may store more than one card under the same buyer reference and/or require an additional identifier for recurring payment. If you are using Braintree, there is no need for additional identifier -- the first credit card available will always be charged. For Adyen and Authorize.net, see `credit_card_authorize_net_payment_profile_token`."
##~ op.parameters.add :dataType => "string", :required => false, :paramType => "query", :name => "credit_card_authorize_net_payment_profile_token", :description => "Additional reference provided by the payment gateway to identify a specific card under the same buyer reference. For Authorize.net, you MUST fill with the 'Payment profile token'. For Adyen, use the `recurringDetailReference` (provided within the response for their `listRecurringDetails` API method), or leave it empty for always charging the LATEST card in their list. Not used for other payment gateways."
##~ op.parameters.add :dataType => "string", :required => true, :paramType => "query", :name => "credit_card_token", :description => "Token used by the payment gateway to identify the buyer -- customer profile ID (Authorize.net), customer ID (Braintree and Stripe), customer alias (Ogone-Ingenico). Some payment gateways may store more than one card under the same buyer reference and/or require an additional identifier for recurring payment. If you are using Braintree, there is no need for additional identifier -- the first credit card available will always be charged. For Authorize.net, see `credit_card_authorize_net_payment_profile_token`."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think even if it is deprecated in the UI some customers on want to be able to set it through the API
Authorize.net is already deprecated but the documentation is still there. When we remove all deprecated gateway we can remove this documentation

@kevprice83 what do you think? @3scale/product

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @hallelujah. I think that returning it into the doc and remove after we completely clean the gateways makes total sense for me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not aware that this was even being deprecated. I think we need to consider who is using it and how they will migrate their customers from it to another payment gateway. Do we have a list of Providers already?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevprice83 On SaaS only one provider. I will answer in the ticket ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hallelujah @kevprice83 I returned the Adyen into the doc. I think we can remove it from the doc only when we completely remove Adyen.

@duduribeiro duduribeiro force-pushed the deprecate_adyen branch 2 times, most recently from 7a23d84 to aa8bde8 Compare June 17, 2019 12:55
@duduribeiro
Copy link
Contributor Author

@3scale/system can you folks review?

🍻

@Martouta Martouta requested a review from a team June 18, 2019 13:02
@secretsurf secretsurf changed the base branch from master to 3scale-2.6.0-ER1 June 19, 2019 09:52
@secretsurf secretsurf changed the base branch from 3scale-2.6.0-ER1 to master June 19, 2019 09:54
@hallelujah hallelujah changed the base branch from master to 3scale-2.6.0-ER1 June 19, 2019 10:00
@hallelujah hallelujah changed the base branch from 3scale-2.6.0-ER1 to master June 19, 2019 10:00
@hallelujah hallelujah changed the base branch from master to 3scale-2.6.0-ER1 June 19, 2019 10:04
@duduribeiro @hallelujah
Deprecate Adyen payment gateway
5a2737b 
Deprecate Adyen payment gateway and remove the option for choosing it in
Billing Settings page. It will continue active for accounts already
using it but they won't be able to switch back if they change it.
@hallelujah hallelujah merged commit 3eeaf3f into 3scale-2.6.0-ER1 Jun 19, 2019
@hallelujah hallelujah deleted the deprecate_adyen branch June 19, 2019 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevprice83 kevprice83 kevprice83 left review comments

@hallelujah hallelujah hallelujah approved these changes

Assignees

@duduribeiro duduribeiro

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@duduribeiro @hallelujah @kevprice83