[do not merge] Default Kubernetes routes to http when the scheme is missing #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by 3scale API to create the provider routes on Kubernetes/Openshift.
…cheme is missing Reverts a recent commit that made https to the default scheme. This is possible due to the new attributes `base_url` and `admin_base_url` returned by the 3scale API.
guicassolato
changed the title
guicassolato
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolls back #321 and relies on the new API attributes
base_urlandadmin_base_urljust introduced in the 3scale Admin API.Do not merge it until 3scale/porta#1869 is merged and deployed, otherwise it will just roll back #321 and reopen THREESCALE-4832.