Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update httpclient to support custom certificate stores [THREESCALE-466] #82

Merged
merged 1 commit into from
Feb 21, 2018
Merged

update httpclient to support custom certificate stores [THREESCALE-466] #82

merged 1 commit into from
Feb 21, 2018

Conversation

mikz
Copy link
Contributor

@mikz mikz commented Feb 21, 2018 •
edited

fixes THREESCALE-466

Set SSL_CERT_FILE environment variable to point to bundle of trusted CA certificates.

@mikz mikz merged commit c9114b9 into master Feb 21, 2018
@mikz mikz deleted the httpclient-ssl-certs branch February 21, 2018 17:52
hallelujah
hallelujah reviewed Feb 21, 2018
View reviewed changes
Copy link
Contributor

@hallelujah hallelujah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC there is another gem to be touched as using the ssl certificates volumes trick did not work

@mayorova
Copy link
Contributor

@hallelujah The other gem was OAuth2::Client, I think it's based on Faraday, that respects SSL_CERT_FILE. I guess we just need QA to confirm it all works :)

@mikz
Copy link
Contributor Author

mikz commented Feb 23, 2018

OAuth2::Client is configured to use httpclient so it works as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hallelujah hallelujah hallelujah left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikz @mayorova @hallelujah