Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch objects from manual parsing to use Codable #161

Open
4 tasks
ryanbourneuk opened this issue Jul 22, 2019 · 0 comments
Open
4 tasks

Switch objects from manual parsing to use Codable #161

ryanbourneuk opened this issue Jul 22, 2019 · 0 comments
Assignees
Labels
codable-refactor Work relating to the Storm Codable refactor

Comments

@ryanbourneuk
Copy link
Contributor

ryanbourneuk commented Jul 22, 2019

Expected Behaviour

Storm objects should be generated using Codable. This will allow us to use Swift object models to define the payload we're expecting, remove code that reduces type-safety, and allow errors to be easily surfaced when generating views at runtime.

Current Behaviour

Storm objects are generated with manual parsing / initialisation, removing type-safety and making issues harder to find.

Possible Solution

(only to be undertaken when test coverage is sufficient)

  • Update storm view objects to use Codable
  • Update storm localisation code to use Codable
  • Update storm page objects to use Codable
  • Update storm object generation to use Codable

Steps to Reproduce (for bugs)

Context

As part of the codable-refactor project, parts of the codebase (mainly storm object related) will be migrated from using manual JSON parsing / initialisation to using Codable. This will allow for increased type-safety, a reduction in boilerplate code, and the ability to easily surface errors when bundles are invalid.

@ryanbourneuk ryanbourneuk self-assigned this Jul 22, 2019
@ryanbourneuk ryanbourneuk added codable-refactor Work relating to the Storm Codable refactor and removed codable-refactor Work relating to the Storm Codable refactor labels Jul 22, 2019
@ryanbourneuk ryanbourneuk added the codable-refactor Work relating to the Storm Codable refactor label Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codable-refactor Work relating to the Storm Codable refactor
Projects
None yet
Development

No branches or pull requests

1 participant