Fix/quiz hides bottom bar when pushed #297
Conversation
Release/v3.0.3
…hidesBottomBarWhenPushed` is `true` for a viewController in the navigationController stack. Only hide bottom bar is this is not the case
…ionContainerViewController`. Now set this when pushing when appropriate
…troller` extension method
| @@ -400,6 +400,8 @@ open class QuizQuestionContainerViewController: AccessibilityRefreshingViewContr | |||
| quiz.currentIndex = quiz.currentIndex + 1 | |||
| guard let questionViewController = quiz.questionViewController() as? QuizQuestionContainerViewController else { return } | |||
| questionViewController.quiz = quiz | |||
| questionViewController.hidesBottomBarWhenPushed = | |||
There was a problem hiding this comment.
I have not set this below on the quiz completion
There was a problem hiding this comment.
That seems correct, the completion won't need to hide the bottom bar because it's already hidden!
There was a problem hiding this comment.
Yeah, you'd safely assume a question came first 😋
| @@ -320,7 +320,7 @@ public extension UINavigationController { | |||
|
|
|||
| guard let _viewController = viewController else { return } | |||
|
|
|||
| _viewController.hidesBottomBarWhenPushed = true | |||
| _viewController.hidesBottomBarWhenPushed = shouldHideBottomBarWhenPushed() | |||
There was a problem hiding this comment.
NOTE: This is for all viewControllers pushed via a Storm link
| /// `hidesBottomBarWhenPushed` to the `return` of this. | ||
| /// This function checks to see if there is another `UIViewController` in the navigation | ||
| /// controller stack (before the to be pushed) which has `hidesBottomBarWhenPushed = true` | ||
| func shouldHideBottomBarWhenPushed() -> Bool { |
There was a problem hiding this comment.
🙇 Looking for those "Exceeding exceptions" 😂
| @@ -400,6 +400,8 @@ open class QuizQuestionContainerViewController: AccessibilityRefreshingViewContr | |||
| quiz.currentIndex = quiz.currentIndex + 1 | |||
| guard let questionViewController = quiz.questionViewController() as? QuizQuestionContainerViewController else { return } | |||
| questionViewController.quiz = quiz | |||
| questionViewController.hidesBottomBarWhenPushed = | |||
There was a problem hiding this comment.
That seems correct, the completion won't need to hide the bottom bar because it's already hidden!
| @@ -1860,7 +1860,7 @@ | |||
| IPHONEOS_DEPLOYMENT_TARGET = 11.0; | |||
| LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks"; | |||
| LIBRARY_SEARCH_PATHS = "$(inherited)"; | |||
| MARKETING_VERSION = 3.0.2; | |||
| MARKETING_VERSION = 3.0.3; | |||
There was a problem hiding this comment.
3.0.3 is already out? Is this just from back-merging into your branch?
There was a problem hiding this comment.
Yep back merging :)
Summary
After
The
navigationControllerwould pop to the rootUIViewControllerbut the tab bar would not be there.For more detail see my docs on
shouldHideBottomBarWhenPushed()Related Issue
https://3sidedcube.atlassian.net/browse/OU20-69
Motivation and Context
Bug fix
How Has This Been Tested?
Tested by running in ARC Emergency
Types of changes
Checklist: