Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create DeclarativeTableViewController and remove DeclarativeSection logic from TableViewController #71

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

BenShutt
Copy link
Contributor

@BenShutt BenShutt commented Jun 10, 2021

Description

Fix issue with implementing both:

tableView(_:titleForHeaderInSection:)
tableView(_:viewForHeaderInSection:)

Use of DeclarativeSection will now require use of DeclarativeTableViewController
Note - this was actually never merged, this is a fix into a release branch.

Motivation and Context

Fixing previous change

How Has This Been Tested?

Referencing apps

Screenshots (if appropriate):

Simulator Screen Shot - iPhone 12 - 2021-06-10 at 11 38 38

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@BenShutt BenShutt merged commit 6728da7 into release/v1.7.0 Jun 14, 2021
@BenShutt BenShutt deleted the fix/declarative-table-view-controller branch June 14, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants