2023 26 aggreate plugin config #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3urobeat
requested changes
Jul 2, 2023
src/dataManager/dataImport.js
Outdated
There was a problem hiding this comment.
Please add line 338 without breaking formatting of the whole file
src/pluginSystem/handlePluginData.js
Outdated
| const fs = require("fs"); | ||
|
|
||
| const PluginSystem = require("./pluginSystem.js"); | ||
|
|
||
| const { logger } = require("output-logger/lib/logger.js"); |
There was a problem hiding this comment.
This import is wrong, it will bypass the log hold back feature. Please use the global logger function or use controller.logger
src/pluginSystem/loadPlugins.js
Outdated
| * Modified By: 3urobeat | ||
| * | ||
| * Copyright (c) 2023 3urobeat <https://github.com/3urobeat> | ||
| * Copyright (c) 2023 3urobeat <https://github.com/HerrEurobeat> |
There was a problem hiding this comment.
Some changes in this file will revert previous fixes, did you pull beforehand?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the feature that Plugin Devs can update their standard config without having to worry that the end user doesn't get the new keys
example
user has:
{ key1: value }but the new config version ships with:
{ key1: value key2: value }