fix: workflow permissions #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downstream workflows were failing because of permissions clash. This workflow has 'read-all'; downstream workflows had 'pull-requests: read'.
Downstream workflow requires 'contents: read' so the top level permissions in this workflow have been updated to match. They were failing previously due to a permissions conflict.
These are the same as the top level permission so are not required.
Workflows have failed since the previous dependabot update with the following error: fatal: could not read Username for 'https://github.com': No such device or address
It appears that without this, the workflow fails, even with top level read permissions defined.
changed-files step is unable to authenticate when set to false. Job level permissions - added back in the previous commit - were not the problem.
lint step cannot authenticate when set to false.
chris3ware
force-pushed
the
fix-workflow-perms
branch
from
30d3aee
to
7b0755e
Compare
chris3ware
added a commit
that referenced
this pull request
Mar 16, 2023
3ware-release bot
pushed a commit
that referenced
this pull request
Mar 16, 2023
## [1.9.10](v1.9.9...v1.9.10) (2023-03-16) ### Bug Fixes * workflow permissions ([#54](#54)) ([af1c78e](af1c78e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since adding
permissions: read-allto the top level of each workflow, the calling workflows are failing due to a clash of permissions.