Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STYLE coding style guide #29

Merged
merged 4 commits into from Sep 10, 2016
Merged

Add STYLE coding style guide #29

merged 4 commits into from Sep 10, 2016

Conversation

@4-20ma
Copy link
Owner

@4-20ma 4-20ma commented May 23, 2015

No description provided.

@4-20ma 4-20ma force-pushed the issue_17_pass_stream_object branch 11 times, most recently from 9f604b3 to 53ce206 May 23, 2015
@4-20ma 4-20ma force-pushed the issue_17_pass_stream_object branch from 1be58f8 to e482ab0 May 24, 2015
- BREAK: This is a breaking change to the interface. ModbusMaster now takes a
  serial object which has been initialized with the appropriate baud rate.
  Any Stream object may be used, including SoftwareSerial.
- As a byproduct of these changes, the library should now be able to be used
  on other architectures besides AVR and SAM.
@4-20ma 4-20ma force-pushed the issue_17_pass_stream_object branch from e482ab0 to 9e611e3 May 24, 2015
@kintel
Copy link
Contributor

@kintel kintel commented Sep 8, 2016

This fixes #17.
I've tested this on an ATmega32u4 as well as under Teensyduino and it works as expected.

I say merge 👍

@4-20ma 4-20ma merged commit ad61f22 into master Sep 10, 2016
@4-20ma 4-20ma deleted the issue_17_pass_stream_object branch Sep 10, 2016
@4-20ma 4-20ma changed the title Add STYLE.md as a coding style guide Add STYLE coding style guide Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.