New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add STYLE coding style guide #29

Merged
merged 4 commits into from Sep 10, 2016

Conversation

Projects
None yet
2 participants
@4-20ma
Owner

4-20ma commented May 23, 2015

No description provided.

4-20ma added some commits May 23, 2015

Fix #17 Pass Stream object to ModbusMaster
- BREAK: This is a breaking change to the interface. ModbusMaster now takes a
  serial object which has been initialized with the appropriate baud rate.
  Any Stream object may be used, including SoftwareSerial.
- As a byproduct of these changes, the library should now be able to be used
  on other architectures besides AVR and SAM.
@kintel

This comment has been minimized.

Show comment
Hide comment
@kintel

kintel Sep 8, 2016

Contributor

This fixes #17.
I've tested this on an ATmega32u4 as well as under Teensyduino and it works as expected.

I say merge 👍

Contributor

kintel commented Sep 8, 2016

This fixes #17.
I've tested this on an ATmega32u4 as well as under Teensyduino and it works as expected.

I say merge 👍

@4-20ma 4-20ma merged commit ad61f22 into master Sep 10, 2016

@4-20ma 4-20ma deleted the issue_17_pass_stream_object branch Sep 10, 2016

@4-20ma 4-20ma changed the title from Add STYLE.md as a coding style guide to Add STYLE coding style guide Sep 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment