Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Skeleton): 子要素によって変化しないSkeletonを追加 #1489

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

Qs-F
Copy link
Collaborator

@Qs-F Qs-F commented Dec 22, 2023

チケット

実装内容

  • 子要素を持たないSkeletonの場合、loading propなどなくてもSkeletonを表示するようにした
  • Textと同じsize propを持つことでTextの代替としてSkeletonを出すことが簡単にできるようにした

スクリーンショット

変更前 変更後

相談内容(あれば)

Copy link

changeset-bot bot commented Dec 22, 2023

🦋 Changeset detected

Latest commit: bf82d19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@4design/for-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Qs-F Qs-F marked this pull request as ready for review December 22, 2023 13:11
Copy link

cloudflare-pages bot commented Dec 22, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bf82d19
Status: ✅  Deploy successful!
Preview URL: https://77a0bb8e.for-ui.pages.dev
Branch Preview URL: https://feat-skeleton-without-childr.for-ui.pages.dev

View logs

@Qs-F Qs-F requested a review from locona December 22, 2023 13:11
Copy link
Contributor

@locona locona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Qs-F Qs-F merged commit ea8110a into main Jan 4, 2024
5 checks passed
@Qs-F Qs-F deleted the feat/skeleton-without-children@1488 branch January 4, 2024 08:17
@github-actions github-actions bot mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

子要素によって変化しないSkeleton
2 participants