Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): default prefixをselectedRow, selectedRows に付与 #1500

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

Qs-F
Copy link
Collaborator

@Qs-F Qs-F commented Jan 5, 2024

チケット

実装内容

  • selectedRow, selectedRows propはuncontrolledなpropなので default prefixつきに変更

スクリーンショット

変更前 変更後

相談内容(あれば)

Copy link

changeset-bot bot commented Jan 5, 2024

🦋 Changeset detected

Latest commit: aab5bf3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@4design/for-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

cloudflare-pages bot commented Jan 5, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: aab5bf3
Status: ✅  Deploy successful!
Preview URL: https://f4dd4c8e.for-ui.pages.dev
Branch Preview URL: https://fix-selectable-table-add-def.for-ui.pages.dev

View logs

@Qs-F Qs-F changed the title Fix/selectable table add default prefix@1499 fix(Table): default prefixをselectedRowに付与 Jan 5, 2024
@Qs-F Qs-F changed the title fix(Table): default prefixをselectedRowに付与 fix(Table): default prefixをselectedRow, selectedRows に付与 Jan 5, 2024
Copy link
Contributor

@locona locona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Qs-F Qs-F marked this pull request as ready for review January 9, 2024 02:59
@Qs-F Qs-F merged commit df44075 into main Jan 9, 2024
5 checks passed
@Qs-F Qs-F deleted the fix/selectable-table-add-default-prefix@1499 branch January 9, 2024 08:30
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table: selectedRow(s)をdefaultSelectedRow(s)に修正
2 participants