Make the routes config dynamically #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `config/laravel-impersonate.php` the `take_redirect_to` and `leave_redirect_to` are hard coded urls. This is fine as long as you don't construct your routes dynamically. In our case we hook into the `RouteServiceProvider` to add a language prefix `de` or `en`, depending on the user settings. Since `route()` in a config file leads to a "Route not defined" error, because Laravel loads the configuration before the routes are registered, the only way to tackle this is to expect a route name. The current implemenation is a BC break. A better implementation would could detect a url and a route and decide this on its own. This is just a first draft to see if you are interested in such a change.
|
Hi @Konafets and thank you for that. |
|
Now it works with named routes and plain url in the config file. |
|
I like it. 👍 There weren't any tests for these before this PR. Not sure if there are plans to have any. |
|
And since it's not BC anymore, maybe remove "BC" from the PR title? |
Konafets
changed the title
|
Merged and tagged 1.1.1. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
config/laravel-impersonate.phpthetake_redirect_toandleave_redirect_toare hard coded urls. This is fine as long as you don't construct your routes dynamically.In our case we hook into the
RouteServiceProviderto add a language prefixdeoren, depending on the user settings.Since
route()in a config file leads to a "Route not defined" error, because Laravel loads the configuration before the routes are registered, the only way to tackle this is to expect a route name.The PR supports the old behavior and adds the new behavior on top.