Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Levenshtein distance on MEW #17

Closed
409H opened this issue Jul 9, 2017 · 4 comments
Closed

Levenshtein distance on MEW #17

409H opened this issue Jul 9, 2017 · 4 comments
Assignees
Milestone

Comments

@409H
Copy link
Owner

409H commented Jul 9, 2017

Implement a Levenshtein distance algorithm to detect similar hostnames to that of myetherwallet.com.

https://en.wikipedia.org/wiki/Levenshtein_distance

This should help detect against myet.herwallet.com and myeth.erwallet.com type of impersonations.

To discuss

  • An acceptable edit distance
  • If there is >= x edit distance, should we disable interaction with the domain or just show a warning?

cc: @tayvano

@409H 409H added this to the v2 milestone Jul 9, 2017
@409H 409H self-assigned this Jul 9, 2017
409H added a commit that referenced this issue Jul 13, 2017
409H added a commit that referenced this issue Jul 13, 2017
Issue #17 - Levenshtein w/ domain whitelist
@409H 409H closed this as completed Jul 13, 2017
@409H
Copy link
Owner Author

409H commented Jul 13, 2017

@sogoiii what's your twitter? I'd like to add your handle when I tweet about the update, if I may

@sogoiii
Copy link
Contributor

sogoiii commented Jul 13, 2017

sure, my twitter handle is @angellopozo i'm the co-founder @hellosugoi as well :)

@409H
Copy link
Owner Author

409H commented Jul 13, 2017

Awesome - will mention both (or 1 depending on char limit) as soon as I've gone over the release again and published to the store 😺

@sogoiii
Copy link
Contributor

sogoiii commented Jul 13, 2017

yea no prob. Ill retweet it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants