Auto battle #4
Closed
Auto battle #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40Cakes
reviewed
Aug 23, 2023
40Cakes
reviewed
Aug 23, 2023
Closed
- Ports from old code: -- added getMovePower to calculate effective move power -- added isValidMove to determine validity of move -- added FindEffectiveMove to find the best move to use -- added BattleOpponent to handle battling opponents - New stuff: -- added handle_move_learning to deal with learning new moves -- added placeholder calculate_new_move_viability to be fleshed out later
# Conflicts: # modules/Menuing.py
- updated all instances of `select_battle_option` to `SelectBattleOption` - updated all instances of `log.info` to `console.print` - removed extraneous print statements
…splayedStringBattle`
# Conflicts: # modules/Stats.py
# Conflicts: # modules/Menuing.py # modules/Stats.py
# Conflicts: # config.yml # modules/Config.py # modules/Memory.py # modules/Stats.py
…bmgba (Linux users are probably gigabrain smart enough to figure it out)
|
Really sorry it's taking me so long to test and review this, but can we please remove all I just got this error |
40Cakes
reviewed
Oct 10, 2023
modules/Stats.py
Outdated
| replace_battler = not battle_won | ||
| else: | ||
| FleeBattle() | ||
| replace_battler = replace_battler or not CheckLeadCanBattle() |
There was a problem hiding this comment.
┌───────────────────── Traceback (most recent call last) ─────────────────────┐
│ E:\Nextcloud\Projects\pokebot-gen3\pokebot.py:43 in MainLoop │
│ │
│ 40 │ │ try: │
│ 41 │ │ │ if GetGameState() == GameState.BATTLE: │
│ 42 │ │ │ │ if OpponentChanged(): │
│ > 43 │ │ │ │ │ EncounterPokemon(GetOpponent()) │
│ 44 │ │ │ │
│ 45 │ │ │ # If the game is still somewhere within the title screen │
│ 46 │ │ │ # with Prof. Birch) there is nothing the bot can do, so i │
│ │
│ ┌──────────────────────────────── locals ─────────────────────────────────┐ │
│ │ ModeSpin = <function ModeSpin at │ │
│ │ 0x0000028C033FE520> │ │
│ │ profile = Profile( │ │
│ │ │ rom=ROM( │ │
│ │ │ │ │ │
│ │ file=WindowsPath('E:/Nextcloud/Projec… │ │
│ │ - Emerald Version (USA, Europe).gba'), │ │
│ │ │ │ game_name='Pokémon Emerald │ │
│ │ (E)', │ │
│ │ │ │ game_title='POKEMON EMER', │ │
│ │ │ │ game_code='BPE', │ │
│ │ │ │ language=<ROMLanguage.English: │ │
│ │ 'E'>, │ │
│ │ │ │ maker_code='01', │ │
│ │ │ │ revision=0 │ │
│ │ │ ), │ │
│ │ │ │ │
│ │ path=WindowsPath('E:/Nextcloud/Projec… │ │
│ │ │ │ │
│ │ last_played=datetime.datetime(2023, │ │
│ │ 10, 10, 22, 52, 33, 11268) │ │
│ │ ) │ │
│ │ verified_that_game_has_started = True │ │
│ └─────────────────────────────────────────────────────────────────────────┘ │
│ │
│ E:\Nextcloud\Projects\pokebot-gen3\modules\Stats.py:674 in EncounterPokemon │
│ │
│ 671 │ │ │ replace_battler = not battle_won │
│ 672 │ │ else: │
│ 673 │ │ │ FleeBattle() │
│ > 674 │ │ replace_battler = replace_battler or not CheckLeadCanBattle() │
│ 675 │ │ if config['battle']['battle'] and config['battle']["replace_l │
│ 676 │ │ │ RotatePokemon() │
│ 677 │ │ if config['battle']["pickup"]: │
│ │
│ ┌──────────────────────── locals ────────────────────────┐ │
│ │ custom_found = False │ │
│ │ pokemon = { │ │
│ │ │ 'name': 'Oddish', │ │
│ │ │ 'id': 43, │ │
│ │ │ 'natID': 43, │ │
│ │ │ 'species': 43, │ │
│ │ │ 'pid': 85797318, │ │
│ │ │ 'nature': 'Bashful', │ │
│ │ │ 'language': 'E', │ │
│ │ │ 'shinyValue': 22537, │ │
│ │ │ 'shiny': False, │ │
│ │ │ 'ot': { │ │
│ │ │ │ 'tid': 17925, │ │
│ │ │ │ 'sid': 13015 │ │
│ │ │ }, │ │
│ │ │ ... +23 │ │
│ │ } │ │
│ └────────────────────────────────────────────────────────┘ │
└─────────────────────────────────────────────────────────────────────────────┘
UnboundLocalError: cannot access local variable 'replace_battler' where it is
not associated with a value
Shutting down...
Turns out this is caused by having an egg in the party 🥚 |
…ttle - added check to ensure `replace_battler` was only checked when battling is enabled
…her to print messages relating to switching a pokemon out - added CheckBattleCanHappen func to prevent bot from doing battle-related stuff if the party doesn't allow it, but also to enable the bot to battle if, say, the user heals at a PC after the bot wass just spinning around because it couldn't battle
…at I don't let temporary turn into permanent) checks to make sure the bot mode isn't manual so that users can regain control at any time by switching to manual mode - this is ugly and i don't like it but it fixes the issue quick so people can use it while i refactor this into a solution that uses fewer loops
…t doesn't display (since it's called like all the time)
This was referenced Oct 25, 2023
Closed
Open
Closed
|
Closing in favour of #117. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes needed to reimplement the automatic battling system. This also contains some handling for new move options-
stopwill stop execution and let the user pick, andcancelwill mash B until the overworld is reached unless the currently displayed text says "Stop learning {whatever the move is}?", in which case it will press A to exit the game's loop.