Draft: ❌Broken: Completely messed auto battle refactor #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ports from old code: -- added getMovePower to calculate effective move power -- added isValidMove to determine validity of move -- added FindEffectiveMove to find the best move to use -- added BattleOpponent to handle battling opponents - New stuff: -- added handle_move_learning to deal with learning new moves -- added placeholder calculate_new_move_viability to be fleshed out later
# Conflicts: # modules/Menuing.py
- updated all instances of `select_battle_option` to `SelectBattleOption` - updated all instances of `log.info` to `console.print` - removed extraneous print statements
…splayedStringBattle`
# Conflicts: # modules/Stats.py
# Conflicts: # modules/Menuing.py # modules/Stats.py
# Conflicts: # config.yml # modules/Config.py # modules/Memory.py # modules/Stats.py
Some users had issues because they closed the console window (instead of the GUI window) to exit the bot. By default, this interrupts the process and prevents the shutdown function from running, so the bot state is lost. This PR adds a handler for that signal.
…bmgba (Linux users are probably gigabrain smart enough to figure it out)
…ttle - added check to ensure `replace_battler` was only checked when battling is enabled
…her to print messages relating to switching a pokemon out - added CheckBattleCanHappen func to prevent bot from doing battle-related stuff if the party doesn't allow it, but also to enable the bot to battle if, say, the user heals at a PC after the bot wass just spinning around because it couldn't battle
…at I don't let temporary turn into permanent) checks to make sure the bot mode isn't manual so that users can regain control at any time by switching to manual mode - this is ugly and i don't like it but it fixes the issue quick so people can use it while i refactor this into a solution that uses fewer loops
…t doesn't display (since it's called like all the time)
40Cakes
changed the title
This was referenced Oct 25, 2023
Closed
Open
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.