Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More tests on update-node-content generic-function. #2

Merged
merged 40 commits into from
May 9, 2022
Merged

More tests on update-node-content generic-function. #2

merged 40 commits into from
May 9, 2022

Conversation

svetlyak40wt
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Mar 13, 2022 •
edited

Pull Request Test Coverage Report for Build 2080559272

  • 219 of 240 (91.25%) changed or added relevant lines in 2 files are covered.
  • 11 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-12.3%) to 87.692%
Changes Missing Coverage Covered Lines Changed/Added Lines %
t/utils/text.lisp 37 47 78.72%
t/document/ops.lisp 182 193 94.3%
Files with Coverage Reduction New Missed Lines %
t/document/ops.lisp 11 89.67%
Totals Coverage Status
Change from base Build 1976515969: -12.3%
Covered Lines: 228
Relevant Lines: 260
💛 - Coveralls

@svetlyak40wt
Removed duplicate test.
b3f7139
@svetlyak40wt
Covered all existing cases for update-node-content.
7849c2e
@svetlyak40wt
Added code to edit code blocks.
895c40f
@svetlyak40wt
Moved key processing code into a data-structure like a keymap.
c568938
@svetlyak40wt
Fixed calling prevent default on keydown.
2165f79
@svetlyak40wt
Fixed uri copying on saving document version.
e306a98
@svetlyak40wt
Fixed find-next-paragraph function.
97685f2
@svetlyak40wt
Now keymap entries have names.
1af4ae4
@svetlyak40wt
Skipping images when searching for the current node.
d8c29ed
@svetlyak40wt
Fixed strange newlines sent by a browser.
6895cdf
@svetlyak40wt
Fixed adding new list items on Option-Enter.
aacbf9b
@svetlyak40wt
Most log entries are now logged as DEBUG.
34c446b
@svetlyak40wt
MVP of alternative keymap for code blocks.
fc078e7
@svetlyak40wt
Fixed code block editing. Now Enter adds a new line inside code block.
6f75159
@svetlyak40wt
Enter adds a new line instead of going to the next paragraph.
9727f3e
@svetlyak40wt
Added code block deletion.
431d60d
@svetlyak40wt
Almost working moving of the cursor inside the code block.
955751c
@svetlyak40wt
Fixed moving from one code-block's line to another.
4f86045
@svetlyak40wt
Pasting to code block keeps new lines as is.
0640166
@svetlyak40wt
Show active code-block.
7cf49f9
@svetlyak40wt
Removed attempt to fix code-block Enter problem on the frontend side.
7a94dee
@svetlyak40wt
Added support for Option+Enter in code blocks.
61c1c41
@svetlyak40wt
Added a function to squash code-block's content.
6438d6d
@svetlyak40wt
Corrected behaviour when editing a paragraph containing an image.
d623417
@svetlyak40wt
Fixed entering hanging spaces after an image.
ef7693d
@svetlyak40wt
Fixed image deletion.
e35459a
@svetlyak40wt
Fixed paragraph splitting and joining for case when there is an image…
92fa468 
… in it.
@svetlyak40wt
Added a hack to calculate new caret position after the image was inse…
ddfef79 
…rted into the document instead of it's markdown representation.
@svetlyak40wt svetlyak40wt merged commit 63a7efc into master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svetlyak40wt @coveralls